Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the stepdown algorithm in lib #5894

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Add the stepdown algorithm in lib #5894

merged 1 commit into from
Aug 31, 2021

Conversation

mbayopanda
Copy link
Contributor

This PR adds the step down algorithm in lib and adds a test for the algo

jmcameron
jmcameron approved these changes Aug 31, 2021
View reviewed changes
Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for now.
We will probably have to restructure it later when we actually start applying it to the BHIMA data. For instance the report will probably have to include selection for the period of coverage, etc.

@mbayopanda
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 31, 2021

Build succeeded:

@bors bors bot merged commit dd96c63 into IMA-WorldHealth:master Aug 31, 2021
@jmcameron jmcameron mentioned this pull request Sep 1, 2021
Closed
@mbayopanda mbayopanda deleted the step-down-test branch September 13, 2021 08:11
@jmcameron jmcameron mentioned this pull request Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcameron jmcameron jmcameron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbayopanda @jmcameron