Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added allocation basis quantity REST API and related regtests #5916

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

jmcameron
Copy link
Collaborator

Updates for cost center analysis

  • Added REST API for cost center allocation basis quantity table
  • Added regression tests for allocation basis items
  • Added regression tests for allocation basis quantity items
  • Added a few more allocation basis items
  • Other updates related to the Fee Center -> Cost Center updates

TESTING

  • In Cost Center Management > Cost Centers > Menu > Allocation bases, note the new predefined items
  • Test adding/editing/deleting allocation basis items
  • In the Cost Center Management > Cost Centers page, try editing one of the centers and choosing one of the new predefined basis items

NOTE: Although my testing with bhima_test (eg, yarn build:db) seems to work, I have not tested this with a production database and the migration process. We need to verify that this works (or update the migrate.sql file as appropriate).

Copy link
Contributor

@mbayopanda mbayopanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed with success and it works as expected

@jmcameron could you update this branch with the latest version of bhima/master, and then I will merge it

@mbayopanda
Copy link
Contributor

LGTM 👍🏽

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 15, 2021

Build succeeded:

@bors bors bot merged commit d266690 into IMA-WorldHealth:master Sep 15, 2021
@jmcameron jmcameron deleted the allocation-basis-quantities branch September 15, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants