Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lot usage schedule display problem #5918

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

jmcameron
Copy link
Collaborator

Fixes occasional wrapping of lot usage schedule lines.

Closes #5897

This was tested on bhima_test and IMCK databases, but not Vanga.

@jmcameron
Copy link
Collaborator Author

@jniles : I think I have this working. I encourage you to try it again.

@jniles jniles added the Bug Fix label Sep 17, 2021
Copy link
Contributor

@jniles jniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapping problem appears fixed:

image

There is still an issue where the columns do not line up. In the screenshot below, the box should end in June but it ends in July:

image

We can merge this PR since the first part is fixed, alternatively, we can work on both bugs before merging. Which would you prefer?

@jmcameron
Copy link
Collaborator Author

jmcameron commented Sep 17, 2021

There is still an issue where the columns do not line up. In the screenshot below, the box should end in June but it ends in July:

image

@jniles : We may need to pair program on this one. It works correctly on my system:
image

Notice that the width of the months are narrower on your system than mine. But I think that the lot schedule bar (green/red) is the same on both systems. So my guess is there is some CSS tweak that we need to make the months work the same on both systems.

I'm open to releasing now and fixing later -- or waiting until we get a chance to figure this out. Your call.

BTW, what browser were you using? Anything odd about your system (display-wise)? I'm running Chrome 93.0.4577.82.

@jniles
Copy link
Contributor

jniles commented Sep 17, 2021

@jmcameron I'm running FF92 on the same machine as you.

I think this is going to be a tricky fix of px in CSS, probably with some hacks. Let's release this and work on the rendering in a different PR.

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 17, 2021

Build succeeded:

@bors bors bot merged commit 46a9da2 into IMA-WorldHealth:master Sep 17, 2021
@jmcameron jmcameron deleted the fix-stock-consumption-schedule branch September 17, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stock Consumption Schedule rendering can sometimes get out of whack
2 participants