Fix migration script on production #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbayopanda
force-pushed
the
fix-migration-on-production
branch
from
16f43d0
to
dc41aaa
Compare
jniles
approved these changes
Sep 28, 2021
|
Merge conflict. |
|
@mbayopanda, can you take a look at this merge conflict? |
mbayopanda
force-pushed
the
fix-migration-on-production
branch
from
dd9f9a8
to
490d597
Compare
jmcameron
reviewed
Sep 28, 2021
| * @author: mbayopanda | ||
| * @desc: add predefined allocation basis | ||
| */ | ||
| INSERT INTO `cost_center_allocation_basis` (`id`, `name`, `units`, `description`, `is_predefined`) VALUES |
There was a problem hiding this comment.
Note: If PR #5947 gets merged first, this will need a little adjusting since I added items 1-3 in my version of migrate.sql. I suggest adding these (4-6) into the previous insert (with 1-3) above.
ALSO, please add the SQL 'IGNORE' keyword in your 'INSERT' statements.
mbayopanda
force-pushed
the
fix-migration-on-production
branch
from
490d597
to
a4e06b1
Compare
|
LGTM. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes migration script on a production data base by :
Also, some fix :