Add cost center in account #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
reviewed
Oct 3, 2021
| @@ -18,6 +18,7 @@ CREATE TABLE `account` ( | |||
| `hidden` TINYINT(1) UNSIGNED DEFAULT 0, | |||
| `created` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, | |||
| `reference_id` TINYINT(3) UNSIGNED DEFAULT NULL, | |||
| `cost_center_id` MEDIUMINT(8) UNSIGNED NULL, | |||
There was a problem hiding this comment.
You will want to put a FOREIGN KEY here.
| @@ -27,6 +27,7 @@ describe('(/accounts) Accounts', () => { | |||
| const responseKeys = [ | |||
| 'id', 'enterprise_id', 'locked', 'created', 'reference_id', | |||
| 'number', 'label', 'parent', 'type_id', 'type', 'translation_key', | |||
| 'cost_center_id', | |||
There was a problem hiding this comment.
Can you add a test where you update a cost center to the integration tests? Just for completeness.
|
@jniles changes landed |
|
Build succeeded: |
jniles
added a commit
to jniles/bhima
that referenced
this pull request
Oct 4, 2021
After merging IMA-WorldHealth#5967, we can now rewrite these functions to use the account table directly. Closes IMA-WorldHealth#5968.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the cost center information in the account.
In the account edit modal:
In the account registry:
