feat(cost center): add link to edit for bases #5976
Conversation
jniles
force-pushed
the
5957-create-or-edit-allocation-keys-by-cost-center
branch
from
6eedb40
to
b92abb7
Compare
|
@mbayopanda, I've fixed all the bugs in this. Can you give me a review? |
jniles
force-pushed
the
5957-create-or-edit-allocation-keys-by-cost-center
branch
from
b92abb7
to
3f7c463
Compare
There was a problem hiding this comment.
I looked this over. It looks good to me. I tested this with bhima_test and the sample data and ti seems to work well.
However, I found one thing disconcerting: When you use the new "Edit allocation basis" for one of the cost centers, it does bring up the right edit modal. However when you are finished with it, it leaves you on the cost_center/allocation_bases (Allocation Bases) page. It seems to me that it should put you back on the Cost center registry page.
Adds a link to the cost center allocation basis edit modal. Closes IMA-WorldHealth#5957.
jniles
force-pushed
the
5957-create-or-edit-allocation-keys-by-cost-center
branch
from
3f7c463
to
247185e
Compare
|
@jmcameron this is a good suggestion. I'll take a whack at it, but I have a feeling it will require a fair amount of work. If it isn't an easy fix, I'll make an issue about it for later. |
Given the time crunch, just create an issue and release the PR. We can fix that later. -Jonathan |
Adds a better UX by navigating back to the $state the user came from after completing the allocation basis form.
|
I think I got this working. Test again? |
|
Works great! |
|
bors r+ |
|
Build succeeded: |
Adds a link to the cost center allocation basis edit modal.
Closes #5957.