Automatically add number of employees to cost centers in step-down cost allocation reports #5977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcameron
force-pushed
the
cost-allocation-num-employees
branch
from
aaf792b
to
6145aa3
Compare
jmcameron
commented
Oct 5, 2021
| const missingCenters = []; | ||
| for (let i = 0; i < computables.length; i++) { | ||
| const basis = computables[i]; | ||
| const data = await allocationQuantities(basis.id); |
There was a problem hiding this comment.
@jniles How do I deal with this?
FIXED.
jmcameron
force-pushed
the
cost-allocation-num-employees
branch
from
6145aa3
to
b527329
Compare
jniles
reviewed
Oct 5, 2021
Ok, I'll see what I can do. -Jonathan |
mbayopanda
reviewed
Oct 6, 2021
jmcameron
force-pushed
the
cost-allocation-num-employees
branch
from
b527329
to
5988683
Compare
jniles
reviewed
Oct 6, 2021
| const newQuantity = ccData[basis.name]; | ||
| // See if there is an existing quantity | ||
| const qRecordId = await db.exec(findQRec, [cc.id, basis.id]); | ||
| if (qRecordId.length > 0) { |
There was a problem hiding this comment.
Can we just delete these values and rewrite? I.e. if we are computing the number of employees, just clear out the old values and then do an INSERT for the rest?
There was a problem hiding this comment.
I'm happy to do that after the demo. By doing drop and insert, I can do it with transactions and clean it up. Lets get this out so we can use it for the demo.
jmcameron
force-pushed
the
cost-allocation-num-employees
branch
from
5988683
to
a534540
Compare
jniles
approved these changes
Oct 6, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds/updates the number of employees for each cost center based on the query proposed by @jniles in its issue:
Closes #5962
I think I was able to verify that computes the correct number of employees for each cost center both in bhima_test and in the vanga dataset (after applying the employees and cost center update scripts from @jniles and @lomamech (respectively).
To use: Go to the "Allocation Keys" page and click on the [Update] button. That will update the cost_center_allocation_base_value table with the items that it can compute (currently only num employees).
This does not work completely yet, because