Fix cost center typos #5986
Merged
Fix cost center typos #5986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcameron
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Looks good. I tested it and it works fine. I have one suggestion. Please change the title of the edit modal from "Edit allocation keys" to "Edit allocation quantities" (we are not editing the keys/bases themselves, but we are editing their quantities/values.
Once you do that, please go ahead and release it.
|
Thanks for the updates! |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes cost center typos and adds a way to show the allocation bases table in the allocation keys module.