Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to use unicode literals (u'') #36

Open
ErwinJunge opened this issue Oct 22, 2017 · 2 comments
Open

Failure to use unicode literals (u'') #36

ErwinJunge opened this issue Oct 22, 2017 · 2 comments
Labels
easy enhancement help-wanted up-for-grabs

Comments

@ErwinJunge
Copy link
Contributor

The code uses string literals '' instead of unicode literals u'' in a lot of places. When combined with potential unicode characters from database content this will break on encoding errors.

We should convert all regular string literals to unicode literals.
@stefanlindblad stefanlindblad mentioned this issue Oct 22, 2017
Closed
@luapmartin luapmartin mentioned this issue Oct 25, 2017
Open
@luapmartin
Copy link

Hi @rohithasrk I have propose a solution by adding unicode_literals from the __future__ package to ensure unicode strings #56

@rohithasrk
Copy link
Contributor

Hi @luapmartin. Will review your PR soon. Give me sometime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy enhancement help-wanted up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErwinJunge @luapmartin @rohithasrk