Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: handle case when all extensions are allowed #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahipjain
Copy link
Member

No description provided.

@akki
Copy link
Member

akki commented Feb 7, 2018

Hi @mahipjain
Thank you for the patch.
I think adding a regression test case would be helpful here. That way this case (when all extensions are allowed) can be ensured to work, each time any change is made to this file.

@rohithasrk
Copy link
Contributor

rohithasrk commented Feb 7, 2018 via email

Copy link
Member

@shaddygarg shaddygarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants