Send notifications only to subscribed users #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihirSachdeva
requested review from
radhika1601,
rish9101 and
SuyashSalampuria
| @@ -86,7 +86,8 @@ def perform_create(self, serializer): | |||
| template = f'{request_product.name} was requested', | |||
| category = request_product.category, | |||
| has_custom_users_target = True, | |||
| persons = list(persons_to_be_notified) | |||
| persons = list(persons_to_be_notified), | |||
| send_only_to_subscribed_users = True | |||
There was a problem hiding this comment.
I don't think send_only_to_subscribed_users is needed here.
Only those who have added the product earlier will be informed.
@MihirSachdeva
There was a problem hiding this comment.
Not using send_only_to_subscribed_users is causing this issue: A user who has requested for/added for sale an item of a particular category is not able to unsubscribe from notifications of that category.
A user should be able to manage his notification subscriptions through the notification settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.