Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB reinsert test failing to compile on GH Actions Inno Setup #278

Open
1 task
meenubhooshanan opened this issue Oct 17, 2022 · 0 comments · May be fixed by #288
Open
1 task

USB reinsert test failing to compile on GH Actions Inno Setup #278

meenubhooshanan opened this issue Oct 17, 2022 · 0 comments · May be fixed by #288
Assignees
@meenubhooshanan
Labels
needs refinement this issue requires further refinement task WS: windows Tasks related to refactoring original code for windows installation
Milestone
Windows Prototype...

Comments

@meenubhooshanan
Copy link
Contributor

Description

When compiling setup.iss using the Inno Setup GUI manually, the installer successfully checks for a USB wifi adapter before installing session-counter. When using Inno Setup with GH Actions, it does not work.

Acceptance Criteria

  • When using the installer executable produced by GH actions, the installer prompts for inserting the USB wifi adapter before installing the program

User Story

No response

Architectural Decision Records (ADRs)

No response
@meenubhooshanan meenubhooshanan added WS: windows Tasks related to refactoring original code for windows installation needs refinement this issue requires further refinement task labels Oct 17, 2022
@meenubhooshanan meenubhooshanan self-assigned this Oct 17, 2022
@meenubhooshanan meenubhooshanan linked a pull request Oct 18, 2022 that will close this issue
[WIP] 278 usb reinsert gh actions #288
Open
@jreme100 jreme100 added this to the Windows Prototype Deployment milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meenubhooshanan meenubhooshanan

Labels
needs refinement this issue requires further refinement task WS: windows Tasks related to refactoring original code for windows installation
Projects
None yet
Milestone
Windows Prototype Deployment
Development

Successfully merging a pull request may close this issue.

[WIP] 278 usb reinsert gh actions IMLS/estimating-wifi
2 participants
@jreme100 @meenubhooshanan