Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review: Incorporate reviewer feedback #49

Merged
merged 32 commits into from
Aug 16, 2021
Merged

JOSS Review: Incorporate reviewer feedback #49

merged 32 commits into from
Aug 16, 2021

Conversation

crvernon
Copy link
Contributor

Purpose:

JOSS Review: Incorporate reviewer feedback

New version:
2.0.2

Related:

Review openjournals/joss-reviews#3601

Resolved:
Resolve #37
Resolve #39
Resolve #40
Resolve #42
Resolve #43
Resolve #46

Incorporated:
#44
#45
#47
#48

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #49 (45f41d7) into main (ba328a4) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   59.66%   59.62%   -0.04%     
==========================================
  Files          22       22              
  Lines        1076     1075       -1     
==========================================
- Hits          642      641       -1     
  Misses        434      434              
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
tests/test_compete.py 96.87% <ø> (ø)
tests/test_nov.py 98.14% <ø> (ø)
tests/test_package_data.py 96.92% <ø> (ø)
tests/test_read_config.py 85.71% <ø> (ø)
tests/test_spatial_reader.py 85.71% <ø> (ø)
tests/test_utils.py 95.23% <ø> (ø)
cerf/__init__.py 100.00% <100.00%> (ø)
tests/test_lmp.py 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba328a4...45f41d7. Read the comment docs.

@crvernon crvernon merged commit 6a06f4e into main Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant