Composer package. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really great project, wanted a composer package for it.
|
👍 |
|
Thanks for looking at this. It's great to see someone wanting to contribute! Some kind of testing was certainly on my list as well, I have some sample XML files sitting around somewhere that demonstrate a few edge cases... |
Closed
|
Definitely send over those edge cases! I started putting together some stuff just using the XML that's in the SimpleXML examples on php.net. Covering the outliers will be even better 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and created a composer package out of this. It would be nice if you would select a formal license again so I can add it to the composer config. Additionally, I went ahead and added coveralls as a dev dependency as I am planning to add unit tests as well as start knocking out the issues list.
Really great project, came across it today and it was an absolutely life saver :)