#22: Disable setting an id during Space creation

IN-CORE · Oct 21, 2021 · e525cc8 · e525cc8
1 parent 49e123d
commit e525cc8
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/server/incore-common/src/main/java/edu/illinois/ncsa/incore/common/models/Space.java b/server/incore-common/src/main/java/edu/illinois/ncsa/incore/common/models/Space.java
@@ -16,6 +16,7 @@
 import dev.morphia.annotations.Property;
 import edu.illinois.ncsa.incore.common.auth.PrivilegeLevel;
 import edu.illinois.ncsa.incore.common.auth.Privileges;
+import org.bson.json.JsonParseException;
 import org.bson.types.ObjectId;
 
 import javax.xml.bind.annotation.XmlRootElement;
@@ -32,7 +33,7 @@
 public class Space {
     @Id
     @Property("_id")
-    private ObjectId id = new ObjectId();
+    private ObjectId id;
 
     @JsonProperty("metadata")
     private SpaceMetadata metadata;
@@ -54,13 +55,11 @@ public Space(String name) {
     }
 
     public String getId() {
-
         return id.toString();
     }
 
-    public void setId(String id) {
-
-        this.id = new ObjectId(id);
+    private void setId(ObjectId id) {
+        throw new JsonParseException("Ids are auto-generated by the system. Setting an id is not allowed");
     }
 
     public String getName() {