Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tornado and Earthquake classes need to have hazardDatasets field #213

Closed
longshuicy opened this issue Sep 12, 2023 · 0 comments · Fixed by #257
Closed

Tornado and Earthquake classes need to have hazardDatasets field #213

longshuicy opened this issue Sep 12, 2023 · 0 comments · Fixed by #257
Assignees
Labels
2storypoint Between 2-6 hours of work, requiring email and/or a brief meeting
Milestone

Comments

@longshuicy
Copy link
Member

longshuicy commented Sep 12, 2023

There are two tasks for this issue:

  • Add hazardDatasets to Tornado
  • For model Earthquake, change rasterDatasets to hazardDatasets

It's good practice to follow other hazards example to have hazardDatasets field. Tornado only has one shapefile, but still it's good to reshape it.

e.g. here is what tornado looks like

{
    "tornadoType": "dataset",
    "id": "5f36ba4b37b8187d11c68375",
    "name": "pytest - Joplin Tornado",
    "description": "Joplin tornado hazard",
    "creator": "vnarah2",
    "threshold": null,
    "thresholdUnit": "mph",
    "spaces": [
        "vnarah2"
    ],
    "date": "2020-08-14T16:22:32+0000",
    "datasetId": "5f36ba4837e20751c116a815"
}

Flood looks like this instead

{
    "floodType": "dataset",
    "id": "5f4d02e99f43ee0dde768406",
    "name": "Lumberton Deterministic Flood - riverine flooding",
    "description": "Lumberton dataset based deterministic hazard - 3 datasets",
    "date": "2020-08-31T14:02:11+0000",
    "creator": "cwang138",
    "spaces": [
        "orphans",
        "incore"
    ],
    "hazardDatasets": [
        {
            "hazardType": "deterministic",
            "datasetId": "5f4d02e352147a614c71960b",
            "demandType": "inundationDepth",
            "demandUnits": "ft",
            "threshold": null,
            "floodParameters": {
                "model": "riverine flooding"
            }
        },
        {
            "hazardType": "deterministic",
            "datasetId": "5f4d02e737e20751c11c0035",
            "demandType": "waterSurfaceElevation",
            "demandUnits": "ft",
            "threshold": null,
            "floodParameters": {
                "model": "riverine flooding"
            }
        }
    ]
}

Model based eq: java/edu/illinois/ncsa/incore/service/hazard/models/eq/EarthquakeModel.java

@longshuicy longshuicy changed the title tornado class need to have hazardDatasets field Tornado class need to have hazardDatasets field Sep 12, 2023
@longshuicy longshuicy added the 2storypoint Between 2-6 hours of work, requiring email and/or a brief meeting label Sep 12, 2023
@longshuicy longshuicy added this to the 1.21.0 milestone Sep 12, 2023
@navarroc navarroc modified the milestones: 1.21.0, 1.22.0 Oct 17, 2023
@navarroc navarroc modified the milestones: 1.22.0, 1.23.0 Nov 7, 2023
@navarroc navarroc modified the milestones: 1.23.0, 1.24.0 Nov 29, 2023
@ylyangtw ylyangtw self-assigned this Dec 14, 2023
@ylyangtw ylyangtw assigned ylyangtw and unassigned ylyangtw Jan 3, 2024
@ylyangtw ylyangtw changed the title Tornado class need to have hazardDatasets field Tornado and Earthquake classes need to have hazardDatasets field Jan 16, 2024
@Rashmil-1999 Rashmil-1999 linked a pull request Jan 16, 2024 that will close this issue
@navarroc navarroc mentioned this issue Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2storypoint Between 2-6 hours of work, requiring email and/or a brief meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants