Semantic service's type endpoint returns the correct object id #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkim312
requested review from
navarroc,
longshuicy,
Vismayak,
ylyangtw and
Rashmil-1999
navarroc
reviewed
Oct 4, 2023
| @@ -109,6 +109,13 @@ public Response listTypes( | |||
|
|
|||
| List<Document> typeList = this.typeDAO.getTypes(); | |||
|
|
|||
| // hackish way of adding "id" field | |||
There was a problem hiding this comment.
I don't think we need to do this here. The listTypes returns all the type "names", no objects, right @longshuicy ?
There was a problem hiding this comment.
If set "detail" flag to true it returns all the objects :-(
We might want to revisit this design at some point...
longshuicy
approved these changes
Oct 4, 2023
navarroc
reviewed
Oct 4, 2023
CHANGELOG.md
Outdated
| @@ -16,6 +16,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
| - Geoserver connection library has been removed and new connection object has been added [#190](https://github.com/IN-CORE/incore-services/issues/190) | |||
| - Semantics should display description instead of title [#206](https://github.com/IN-CORE/incore-services/issues/206) | |||
|
|
|||
| ### Fixed | |||
| - Semantic services endpoint returns correct ID [#206](https://github.com/IN-CORE/incore-services/issues/206) | |||
navarroc
approved these changes
Oct 4, 2023
ylyangtw
pushed a commit
that referenced
this pull request
Oct 11, 2023
* 190 upgrade geoserver connection (#204) * saving purpose * Created geoserver rest api object * modified remove layers * clean up build.gradle * blocked geoserver upload if there is no prj file * Fixes #208 - added attenuation model Sadigh et al. 1997 (#210) * 188 redo adding owner item to dataset and delete by only owner (#196) * added owner to dataset * added for hazard and dfr3 * delete and put has been modified based on ownership * added a function that the admin group can delete * use isAdmin from Authorizer * changed one missing isAdmin to authorizer * Add Template API endpoint (#215) * Remove LdapClient and refactor methods in Authorizer class in interface * Warning changes * work in progress * fixed csv writer * fix csv file generation * add shapefile support * add changelog entry --------- Co-authored-by: YONG WOOK KIM <ywkim312@users.noreply.github.com> * 206 show description instead of title for semantics table (#209) * display description instead of title * add entry in changelog * 221 add semantic template link in the html (#223) * add download * place link * Semantic service's type endpoint returns the correct object id (#228) * type returns the correct object id * fixed changelog * 217 add jupyter quota to incore service (#218) * add incore lab quota * match the words to make life easier * changelog * add toJson method to serialize the model * add todo * usage doesn't have service and incoreLab * Allow semantics to be added to space (#230) * allow add semantics * fix more logic * update comment * changelog and version bump up --------- Co-authored-by: YONG WOOK KIM <ywkim312@users.noreply.github.com> Co-authored-by: Chris Navarro <cmnavarr@illinois.edu> Co-authored-by: Rashmil Panchani <32737711+Rashmil-1999@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.