Add GitHub actions to run unit tests and publish docker images #20 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
commented
Oct 7, 2021
.github/workflows/ci.yml
Outdated
| run: | | ||
| if [ "${{ github.event.release.target_commitish }}" != "" ]; then | ||
| BRANCH="${{ github.event.release.target_commitish }}" | ||
| elif [[ $GITHUB_REF =~ pull ]]; then |
There was a problem hiding this comment.
This probably needs to be updated to check for "pull/" because it might hit this condition even if the branch name contains the work "pull". e.g. "pull-from-api"and I enable the trigger to run for other branches.
There was a problem hiding this comment.
we can probably use:
Suggested change
| elif [[ $GITHUB_REF =~ pull ]]; then | |
| elif [ "${{github.event.pull_request.number}}" != "" ]; then | |
| BRANCH="${{github.event.pull_request.number}}" |
robkooper
requested changes
Oct 15, 2021
.github/workflows/ci.yml
Outdated
| run: | | ||
| if [ "${{ github.event.release.target_commitish }}" != "" ]; then | ||
| BRANCH="${{ github.event.release.target_commitish }}" | ||
| elif [[ $GITHUB_REF =~ pull ]]; then |
There was a problem hiding this comment.
we can probably use:
Suggested change
| elif [[ $GITHUB_REF =~ pull ]]; then | |
| elif [ "${{github.event.pull_request.number}}" != "" ]; then | |
| BRANCH="${{github.event.pull_request.number}}" |
…20' into add-github-actions-to-services-#20
robkooper
approved these changes
Oct 19, 2021
ywkim312
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Please see the code comments for working.
Please looks at the condition I used to build/publish docker images, something could be wrong there. I'm still testing the PR and push(to develop) conditions - so far only tested on my branch