Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

283 uploaded joined shapefile to geoserver has missing values #284

Conversation

navarroc
Copy link
Member

I switched the call from outToShapefile to outToGpkgFile and fixed the issue with using the gpkg file. I have not tested upload to the geoserver, but I did test the join on my local and it looks to be working correctly.

@navarroc navarroc linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed to incore-dev and tested.
Got a 500 Internal Error. Data service pod logs are not very helpful

at java.base/java.lang.Thread.run(Unknown Source)
Mar 13, 2024 3:10:42 AM org.geotools.jdbc.JDBCDataStore getSQLTypeNames
WARNING: Fetching fields from Database
Mar 13, 2024 3:13:15 AM org.geotools.jdbc.JDBCDataStore getSQLTypeNames
WARNING: Fetching fields from Database

One interesting thing I found is YWK might revert back to shapefile because geopackage is posting this layer with the store name as the dataset id but layer name as something completely different
image

Apart from the wrong layer name (and 500 error), the layer seems to be correct
image

@navarroc
Copy link
Member Author

I deployed to incore-dev and tested. Got a 500 Internal Error. Data service pod logs are not very helpful

at java.base/java.lang.Thread.run(Unknown Source)
Mar 13, 2024 3:10:42 AM org.geotools.jdbc.JDBCDataStore getSQLTypeNames
WARNING: Fetching fields from Database
Mar 13, 2024 3:13:15 AM org.geotools.jdbc.JDBCDataStore getSQLTypeNames
WARNING: Fetching fields from Database

One interesting thing I found is YWK might revert back to shapefile because geopackage is posting this layer with the store name as the dataset id but layer name as something completely different image

Apart from the wrong layer name (and 500 error), the layer seems to be correct image

So it uploads OK (besides the name issue), but still throws an error? I'm guessing the internal error comes from the GeoserverUtils.uploadGpkgToGeoserver(dataset.getId(), geoPkgFile) not getting the return type it expects. Any thoughts on how to address this? Is there a way to test this locally to push to our geoserver so we can put in some debug statements? I see that it automatically sets "renameLayer=True". I'm really not sure since this code is not very familiar to me.

* pass in dataset id as the default join

* one more fix
Copy link
Contributor

@ylyangtw ylyangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@longshuicy longshuicy merged commit 55c239e into develop Mar 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploaded joined shapefile to geoserver has missing values
3 participants