Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #299 - upgraded OpenCSV to version 5.9 #300

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixes #299 - upgraded OpenCSV to version 5.9 #300

wants to merge 3 commits into from

Conversation

navarroc
Copy link
Member

@navarroc navarroc commented Jul 8, 2024

Upgraded openCSV from version 4.6 to 5.9. Some deprecated constructors were removed so I updated the code accordingly and added some new exceptions.

I also created a unit test to verify the parser settings should read a CSV correctly.

@navarroc navarroc linked an issue Jul 8, 2024 that may be closed by this pull request
Upgrade opencsv library to version 5 #299
Open
@navarroc
Copy link
Member Author

I also upgraded dom4j since it was a small increment

longshuicy
longshuicy approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Services build successfully and all the test passed.
Briefly tried listing dataset, dfr3, eq. All seems to work normally.
Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longshuicy longshuicy longshuicy approved these changes

@ywkim312 ywkim312 Awaiting requested review from ywkim312

@Rashmil-1999 Rashmil-1999 Awaiting requested review from Rashmil-1999

@ylyangtw ylyangtw Awaiting requested review from ylyangtw

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade opencsv library to version 5
2 participants
@navarroc @longshuicy