Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DFR3 service's out of index error #564

Conversation

ywkim312
Copy link
Member

@ywkim312 ywkim312 commented May 6, 2024

Test this with road_dmg.ipynb after installing the PR locally by pip install . -U

@ywkim312 ywkim312 linked an issue May 6, 2024 that may be closed by this pull request
@ywkim312 ywkim312 self-assigned this May 6, 2024
@navarroc
Copy link
Member

Looks like the fragility needs distance, which this dataset has on production: 60ba6340aed73f24c5c5eaca

Copy link
Member

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_roaddamage.py and the road_dmg.ipynb notebook both pass now

@longshuicy longshuicy merged commit 57cb035 into develop May 30, 2024
7 checks passed
@longshuicy longshuicy deleted the 555-dfr3service-error-when-fragility-mapping-rule-set-is-empty branch May 30, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DFR3Service error when fragility mapping rule set is empty
3 participants