Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Base IRI configurable #617

Merged
merged 17 commits into from Aug 22, 2022
Merged

Make Base IRI configurable #617

merged 17 commits into from Aug 22, 2022

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Jun 16, 2022

This PR:

  • Adds ability to properly configure base IRI tested here: https://gitlab.c-path.org/c-pathontology/critical-path-ontology.
    • Introducing OBOBASE variable, because the default for most of the imports should still be OBO. This can be overwritten, of course, by the user by setting mirror_from. (see makefile changes)
    • Various changes in template/_dynamic_files.jinja2, in particular about the PURLs for the imports.
  • Removes redundant editors documentation
  • Removes redundant sparql query template/src/sparql/class-count-by-prefix.sparql
  • Removes a handful of redundant prefixes in sparql queries
  • EDIT: Makes uribase_suffix configurable. This is used for assigning ontology IRIs to ontology internal files, like imports, and

@matentzn matentzn self-assigned this Jun 19, 2022
@matentzn matentzn added this to the 1.3.2 milestone Jun 19, 2022
@matentzn matentzn added the cpath label Aug 7, 2022
@matentzn matentzn requested a review from gouttegd August 20, 2022 17:02
@matentzn matentzn marked this pull request as ready for review August 20, 2022 17:03
template/_dynamic_files.jinja2 Outdated Show resolved Hide resolved
odk/odk.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants