Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow attribute updates in large attack graphs #108

Closed
tobi18991 opened this issue Mar 20, 2023 · 0 comments · Fixed by #110
Closed

Slow attribute updates in large attack graphs #108

tobi18991 opened this issue Mar 20, 2023 · 0 comments · Fixed by #110
Assignees
Labels
bug Something isn't working

Comments

@tobi18991
Copy link
Member

For large attack graphs, e.g., 30 nodes, 100 edges, it takes a long time until the whole graph was updated.

The problem lies in the AttributeRenderer.recalculateAllCells() method. It starts a recursive call to refresh cell attributes from EVERY cell. Hence, many cells are updated several times even though (theoretically) one call would be sufficient.

To fix this issue, a mechanism to mark already visited nodes would be needed and a node's attributes shall only be updated when ALL children were already updated.

Tips for implementation: The root of the mxGraph structure is NOT the root of the (visible) graph.

@tobi18991 tobi18991 added bug Something isn't working enhancement New feature or request labels Mar 20, 2023
@tobi18991 tobi18991 self-assigned this Mar 20, 2023
@tobi18991 tobi18991 removed the enhancement New feature or request label Mar 21, 2023
tobi18991 added a commit that referenced this issue Mar 22, 2023
* Add docstrings for introduced methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant