Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undos do not trigger graph updates #109

Closed
tobi18991 opened this issue Mar 21, 2023 · 0 comments · Fixed by #114
Closed

Undos do not trigger graph updates #109

tobi18991 opened this issue Mar 21, 2023 · 0 comments · Fixed by #114
Assignees
@tobi18991
Labels
bug Something isn't working

Comments

@tobi18991
Copy link
Member

Whenever an undo is triggered, e.g., undoing the accidential deletion of an edge, values are not recalculated. For instance, removing edges from security measures to attack steps does not trigger a recalculation of the aggregated values.

Before removing the edge:
Edge exists with correct values

After removing the edge:
Edge removed with correct (new) values

Undoing the edge removal:
Edge exists with incorret values
@tobi18991 tobi18991 added the bug Something isn't working label Mar 21, 2023
@tobi18991 tobi18991 self-assigned this Mar 21, 2023
tobi18991 added a commit that referenced this issue Mar 23, 2023
@tobi18991
Trigger graph updates also after undos #109
d3ecbd9 
* Remove listeners for CELLS_ADDED and CELLS_REMOVED
* Use CHANGE event to react to cell removals and insertions
@tobi18991 tobi18991 mentioned this issue Mar 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobi18991 tobi18991

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trigger graph updates also after undos INCYDE-GmbH/drawio-plugin-attackgraphs
1 participant
@tobi18991