Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent edge markings #119

Closed
tobi18991 opened this issue Mar 28, 2023 · 0 comments · Fixed by #120
Closed

Inconsistent edge markings #119

tobi18991 opened this issue Mar 28, 2023 · 0 comments · Fixed by #120
Assignees
@tobi18991
Labels
bug Something isn't working

Comments

@tobi18991
Copy link
Member

tobi18991 commented Mar 28, 2023 •
edited

For some odd reason, the marking of edges sometimes does not work correctly. Even though the _marking aggregated value exists, the corresponding edge to the child node is not always highlighted.

Example is shown below:
Incorrect edge marking

Yet, the left node marks the edge to the green attack step node:
Correct edge marking
@tobi18991 tobi18991 added the bug Something isn't working label Mar 28, 2023
@tobi18991 tobi18991 self-assigned this Mar 28, 2023
tobi18991 added a commit that referenced this issue Mar 28, 2023
@tobi18991
Fix inconsistent edge markings #119
b0fe631 
* Seperated the highlighting from the marking logic
@tobi18991 tobi18991 mentioned this issue Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobi18991 tobi18991

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inconsistent marking of edges INCYDE-GmbH/drawio-plugin-attackgraphs
1 participant
@tobi18991