Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include option to separate functions from .drawio file #132

Closed
Tracked by #83
RichardPoschingerINCYDE opened this issue Apr 27, 2023 · 2 comments
Closed
Tracked by #83

Include option to separate functions from .drawio file #132

RichardPoschingerINCYDE opened this issue Apr 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@RichardPoschingerINCYDE
Copy link
Member

Proposal

It might be beneficial for pre-defined (written by the plugin authors) functions to be separated from the .drawio file (and its graph). The function definition could be included in the release file of the plugin.

Options

This could result in the following options:

  • Pre-defined function:
    • Internal function file
    • .drawio file referring to the function definition
  • User-defined function:
    • .drawio file including the function definition

Advantage:

  • Functions can be updated to provide improvements of bugfixes (affects especially long-term projects)
  • Error prone copy-paste process during function updates is eliminated
@tobi18991 tobi18991 added the enhancement New feature or request label Apr 27, 2023
@Mq89
Copy link
Member

Mq89 commented Apr 27, 2023 •
edited

I do understand your point. But I would like to keep the abstract concept (graphs and aggregation) apart from the concrete methodology (attributes from 50701, RKL and 21434 (in the future)). In other words, I do not want TS 50701 specific things in attackgraphs.js.

Currently, I use the templates as reference for the latest version of the functions.

Maybe we can ship the functions (including maybe multiple versions of them) in separate files and provide an "update functions" feature where the user can easily select the desired update file of the functions to avoid manual copy-paste.

@RichardPoschingerINCYDE
Copy link
Member Author

Sounds like a good alternative solution!

tobi18991 added a commit that referenced this issue May 25, 2023
@tobi18991
Add file import dialog #132
320eac7 
The dialog handles *.json files containing import information.

* Move `getAddButton()` to `DefaultAttributesDialog`
* Fix `attackgraphs.noAttributes` language resource item
tobi18991 added a commit that referenced this issue May 26, 2023
@tobi18991
Apply import of attributes and functions #132
9acfce5 
* Fix TS50701 template
* Re-arrange function list dialog
tobi18991 added a commit that referenced this issue May 30, 2023
@tobi18991
Add global import of the whole template file #132
d3063e9
tobi18991 added a commit that referenced this issue Jun 1, 2023
@tobi18991
Add export template dialog #132
98bc71c 
* Refactor `ImportDialog` by using an abstract `FileDialog`
* Rename `AGImportFile` to `TemplateFile`
* Rename `ImportType` to `TemplateType`
* Add seperators to `Attack Graphs` menu
tobi18991 added a commit that referenced this issue Jun 1, 2023
@tobi18991
Add template files to the repository #132
11d1335
This was referenced Jun 1, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mq89 @tobi18991 @RichardPoschingerINCYDE