Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix execution of conversion script in testsuite #81

Merged
merged 1 commit into from Apr 17, 2018
Merged

Fix execution of conversion script in testsuite #81

merged 1 commit into from Apr 17, 2018

Conversation

mschmidt87
Copy link
Collaborator

@mschmidt87 mschmidt87 commented Apr 14, 2018 •
edited

This PR fixes the testsuite on travis by executing the conversion script using bash.

Fixes #80

@coveralls
Copy link

coveralls commented Apr 14, 2018 •
edited

Coverage Status

Coverage increased (+14.9%) to 92.308% when pulling db71af8 on mschmidt87:bug/test_bash_script into 04b3025 on INM-6:master.

@mschmidt87 mschmidt87 force-pushed the bug/test_bash_script branch 4 times, most recently from 2ea3020 to 6813aae Compare April 14, 2018 02:32
jakobj
jakobj approved these changes Apr 15, 2018
View reviewed changes
Copy link
Collaborator

@jakobj jakobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and travis is happy! 👍 just one question: why do we need to execute the script with python? shouldn't it also work without explicitly putting python in the command?

@mschmidt87
Copy link
Collaborator Author

Normally yes, but I did not figure out a way to combine executing the script with ./ and the absolute path that is necessary to find it in the first place.

@mschmidt87 mschmidt87 changed the title Execute conversion script in testsuite with bash command Fix execution of conversion script in testsuite Apr 17, 2018
@jakobj
Copy link
Collaborator

jakobj commented Apr 17, 2018

OK, fair enough, this is not critical anyway, merging.

@jakobj jakobj merged commit 02899ca into INM-6:master Apr 17, 2018
@mschmidt87 mschmidt87 deleted the bug/test_bash_script branch April 20, 2018 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobj jakobj jakobj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Python 2.7 tests
3 participants
@mschmidt87 @coveralls @jakobj