Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Related posts widget sometimes duplicates current post #1381

Closed
aschweigert opened this issue Dec 6, 2016 · 2 comments
Closed

Related posts widget sometimes duplicates current post #1381

aschweigert opened this issue Dec 6, 2016 · 2 comments
Assignees
@benlk
Labels
priority: normal Must be completed before release of this version of plugin. type: bug
Milestone
hotfix

Comments

@aschweigert
Copy link

See: http://support.largoproject.org/helpdesk/tickets/319

Essentially, it appears we don't explicitly exclude the current post when we run the query in the widget so it sometimes will show the current post at the top of the list of related stories.

We should check for and explicitly exclude the global $post in the widget to make sure this doesn't happen.
@aschweigert aschweigert added priority: normal Must be completed before release of this version of plugin. type: bug labels Dec 6, 2016
@aschweigert aschweigert added this to the hotfix milestone Dec 6, 2016
@benlk benlk mentioned this issue Dec 9, 2016
Closed
benlk added a commit that referenced this issue Dec 9, 2016
@benlk
Probable fix for #1381
e1c7500 
I'm not able to duplicate the bug described in #1381, but this looks like a fix: exclude the current post from the posts that get returned in any query in the Largo_Related class, which is what feeds the Largo Related Posts widget.

Please watch tests on this one.
@benlk benlk mentioned this issue Dec 9, 2016
Merged
benlk added a commit that referenced this issue Dec 13, 2016
@benlk
Merge pull request #1385 from INN/1381-possible-fix
922ede2 
Probable fix for #1381
@rclations
Copy link

fixed with #1385

@benlk benlk reopened this Feb 22, 2017
@benlk benlk mentioned this issue Feb 22, 2017
Merged
@benlk
Copy link
Collaborator

benlk commented Feb 22, 2017

Reopening for #1403

@benlk benlk closed this as completed Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlk benlk

Labels
priority: normal Must be completed before release of this version of plugin. type: bug
Projects
None yet
Milestone
hotfix
Development

No branches or pull requests
3 participants
@aschweigert @benlk @rclations