Post Comment Errors #1382
Merged
Post Comment Errors #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
On at least some post comments, a PHP error is being printed to the front end.
Why
We're using the
get_avatarhook, who's third parameter$id_or_email, is specified atA user ID, email address, or comment object.We are only accommodating for a user ID or email address, and do not have code to accept a comment object.
Reference: https://codex.wordpress.org/Plugin_API/Filter_Reference/get_avatar
The Fix
I've updated the offending function using the example from the codex page to also accept comment objects