Bugfix for IW-32, staff roster avatars master #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnagle
added a commit
that referenced
this pull request
Jun 23, 2015
Bugfix for IW-32, staff roster avatars master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes tests!
Why
Updating user metadata prevented the user from displaying in the
[roster]shortcode.Previously, updating a user's metadata by saving their profile changed some fields from "" to "off". The roster shortcode checked that those fields were not-empty instead of checking for their false value.
This change was previously applied in the staff roster widget, but the widget does not use
largo_render_user_list.