Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pip requirement.txt in Largo #1359

Closed
1 of 6 tasks
benlk opened this issue Oct 24, 2016 · 1 comment
Closed
1 of 6 tasks

Include pip requirement.txt in Largo #1359

benlk opened this issue Oct 24, 2016 · 1 comment
Labels
priority: normal Must be completed before release of this version of plugin. status: needs docs

Comments

@benlk
Copy link
Collaborator

benlk commented Oct 24, 2016

Running sphinx (any by extension grunt build, which wraps it) requires sphinx and related programs, which are currently managed by a requirements.txt file for pip. That file is typically contained in umbrella repositories, using the example fabfile from the deploy tools as an example.

Why is there a fabfile in the deploy tools? To take care of the requirements for the deploy tools.

Why are Largo-specific requirements included in the largo umbrella requirements.txt? Because that was probably what was easiest at the time, when all our sites were under one repository.

We should:

  • create a requirements.txt for Largo that specifies what's required for this project in particular
  • exclude it from the git sftp list of things that gets deployed
  • make sure that we can run grunt build without errors, and change docs in largo.readthedocs.io to account for the changed location of the fabfile.
    • probably requires creating a testing-purposes virtualenv
    • create an issue to upgrade Largo and inn/deploy-tools to pipenv
  • improve docs related to this
@benlk benlk added priority: normal Must be completed before release of this version of plugin. status: needs docs labels Oct 24, 2016
@rclations rclations modified the milestone: Backlog Apr 11, 2017
@benlk benlk removed this from the 0.6 - Gutenberg, SEO, Performance milestone Nov 8, 2018
@benlk
Copy link
Collaborator Author

benlk commented Dec 5, 2018

requirements.txt:

sphinx==1.2.3
sphinxcontrib-phpdomain==0.1.4

#1456 will remove the need for sphinx, ideally, but until then, we should ship requirements.txt in Largo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. status: needs docs
Projects
None yet
Development

No branches or pull requests

2 participants