Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test PostTemplatesTestFunctions::test_insert_image_no_thumb #1404

Closed
benlk opened this issue Feb 22, 2017 · 0 comments · Fixed by #1503
Closed

Failing test PostTemplatesTestFunctions::test_insert_image_no_thumb #1404

benlk opened this issue Feb 22, 2017 · 0 comments · Fixed by #1503
Assignees
Labels
priority: normal Must be completed before release of this version of plugin. status: needs tests type: bug

Comments

@benlk
Copy link
Collaborator

benlk commented Feb 22, 2017

Sample error failed test: https://travis-ci.org/INN/Largo/jobs/204338888

Affecting all versions of Largo, after PR #1400 but, curiously, not #1400 itself.

This failing test is a known problem; it's not urgent, but it did need to be noted.

There was 1 failure:
1) PostTemplatesTestFunctions::test_insert_image_no_thumb
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<h2>Headings</h2>
+'<p><img src="http://example.org/wp-content/uploads/2017/02/cat-771x510.jpg" alt="1559758083_cef4ef63d2_o" width="771" height="475" class="alignnone size-large wp-image-283" /></p>
+<h2>Headings</h2>
 <p>Integer posuere erat a ante venenatis dapibus posuere velit aliquet. Sed posuere consectetur est at lobortis. Nulla vitae elit libero, a pharetra augue. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus. Donec sed odio dui.</p>'
@benlk benlk added priority: normal Must be completed before release of this version of plugin. status: needs tests type: bug labels Feb 22, 2017
@rclations rclations modified the milestone: Backlog Apr 11, 2017
@rclations rclations modified the milestones: 0.6 - Performance & SEO, Backlog Jun 3, 2017
benlk added a commit that referenced this issue Jul 25, 2018
…img tag, as it's not necessary for this function and appears to be the cause of #1404
@benlk benlk changed the title Failing test Failing test PostTemplatesTestFunctions::test_insert_image_no_thumb Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. status: needs tests type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants