Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Grunt dependencies #1540

Closed
benlk opened this issue Oct 2, 2018 · 5 comments · Fixed by #1899
Closed

Update Grunt dependencies #1540

benlk opened this issue Oct 2, 2018 · 5 comments · Fixed by #1899
Assignees
@rlambertsen
Labels
priority: normal Must be completed before release of this version of plugin. type: tech debt For necessary updates because code is old
Projects
Largo 0.7
Milestone
0.7 - Foundation ...

Comments

@benlk
Copy link
Collaborator

benlk commented Oct 2, 2018

In package.json, update everything to the latest version, then run all the grunt tasks to see what's broken. Then fix.
@benlk benlk added priority: normal Must be completed before release of this version of plugin. type: tech debt For necessary updates because code is old labels Oct 2, 2018
@benlk benlk added this to the 0.6 - Performance & SEO milestone Oct 2, 2018
@benlk
Copy link
Collaborator Author

benlk commented Oct 2, 2018

This may affect #1163 and should be used as an opportunity for #655

@benlk
Copy link
Collaborator Author

benlk commented Nov 8, 2018

using https://github.com/INN/umbrella-energynewsnetwork/blob/master/wp-content/themes/midwestenergynews/package.json as a template.

@benlk
Copy link
Collaborator Author

benlk commented Nov 8, 2018 •
edited
Loading

grunt-po2mo requires Grunt 0.4.1ish, so this would need to cover #1535 as well.

grunt-pot the same.

@benlk benlk mentioned this issue Nov 8, 2018
Closed
@benlk
Copy link
Collaborator Author

benlk commented Jun 13, 2019

We've replaced grunt-pot with a shell wrapper around wp i18n make-pot . lang/largo.pot

grunt-po2mo experiences problems with sync-exec, so we will want to investigate alternatives, including https://www.npmjs.com/package/@fltwk/grunt-po2mo

@benlk benlk mentioned this issue Jul 19, 2019
Closed
5 tasks
@benlk
Copy link
Collaborator Author

benlk commented Aug 21, 2019

Update Grunt dependencies

@benlk benlk added this to To do in Largo 0.7 via automation Aug 21, 2019
@benlk benlk mentioned this issue Aug 22, 2019
Open
@rlambertsen rlambertsen self-assigned this Mar 27, 2021
rlambertsen added a commit that referenced this issue Mar 29, 2021
@rlambertsen
#1540; Update Grunt dependencies; add package.json lock file to keep,…
ac841d6 
… update change-log with changes
@rlambertsen rlambertsen mentioned this issue Mar 29, 2021
Merged
5 tasks
rlambertsen added a commit that referenced this issue Mar 29, 2021
@rlambertsen
#1540; update change-log with changes and links to issue and PR
50269f4
rlambertsen added a commit that referenced this issue Mar 30, 2021
@rlambertsen
#1540; revert removing grunt actions from build command
65751ff
@joshdarby joshdarby linked a pull request Apr 16, 2021 that will close this issue
#1540 update grunt dependencies #1899
Merged
5 tasks
Largo 0.7 automation moved this from To do to Done Apr 16, 2021
rlambertsen added a commit that referenced this issue Apr 16, 2021
@rlambertsen
Merge pull request #1899 from WPBuddy/#1540_Update_Grunt_dependencies
fbb287e 
#1540 update grunt dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlambertsen rlambertsen

Labels
priority: normal Must be completed before release of this version of plugin. type: tech debt For necessary updates because code is old
Projects
Largo 0.7
  
Done
Milestone
0.7 - Foundation for Customization
Development

Successfully merging a pull request may close this issue.

#1540 update grunt dependencies WPBuddy/largo
2 participants
@benlk @rlambertsen