Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating social buttons obscured by body text #1576

Closed
tylermachado opened this issue Nov 16, 2018 · 4 comments
Closed

Floating social buttons obscured by body text #1576

tylermachado opened this issue Nov 16, 2018 · 4 comments

Comments

@tylermachado
Copy link

The popover from the floating social buttons is being obscured by the body text. Looks like a z-index bump on the floating social buttons parent element ought to fix it.

image

@benlk
Copy link
Collaborator

benlk commented Nov 16, 2018

In 0.6, the floating social buttons were moved down in the z-index stack so that they'd pass behind fullwidth images in Gutenberg. Could this be fixed by increasing the z-index height for the menu?

@tylermachado
Copy link
Author

Doesn't look like it -- I think that only moves the menu up within its parent element, even if I attach an extra position:absolute on it. So it seems to be reliant on the z-index of the parent.

@benlk
Copy link
Collaborator

benlk commented Nov 16, 2018

Copying note from Slack:

So the z-indexes of the relevant items need to be:

  • Sticky Nav
  • .alignfull
  • FSB/menu
  • paragraph/list/etc text at normal Z-index

@benlk
Copy link
Collaborator

benlk commented Jan 31, 2019

Adding another bug case in current 0.5-dev: In the single-column template, the sticky nav buttons div#floating-social-buttons at z-index: 0 are actually beneath the transparent div#main at z-index: 1. Those two divs are sibling children of div#page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants