Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highly annoying debug notice in sticky nav #1623

Closed
benlk opened this issue Jan 31, 2019 · 3 comments
Closed

Highly annoying debug notice in sticky nav #1623

benlk opened this issue Jan 31, 2019 · 3 comments
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. priority: low Nice-to-have in a release. type: bug
Milestone
0.6.2

Comments

@benlk
Copy link
Collaborator

benlk commented Jan 31, 2019

Notice: Trying to get property 'has_children' of non-object in /wp-content/themes/largo/inc/nav-menus.php on line 87

If there are a log of items in the sticky nav, this will obscure the entire screen when the sticky nav is visible and WP_DEBUG is true.

Part of #1492.
@benlk benlk added type: bug priority: high Either blocks work on a priority-normal task or a solution here informs other work. priority: low Nice-to-have in a release. labels Jan 31, 2019
@benlk benlk added this to the 0.6.2 milestone Jan 31, 2019
This was referenced Jan 31, 2019
Open
Merged
Closed
@benlk
Copy link
Collaborator Author

benlk commented Jan 31, 2019

Closed with #1624.

@benlk benlk closed this as completed Jan 31, 2019
benlk added a commit to INN/umbrella-publicsource that referenced this issue Jan 31, 2019
@benlk
Update Largo to fix for WPBuddy/largo#1623
6d7c340
@benlk benlk reopened this Feb 2, 2019
@benlk
Copy link
Collaborator Author

benlk commented Feb 2, 2019

Cannot use object of type stdClass as array in /Users/blk/sites/largo/wp-content/themes/largo/inc/nav-menus.php:87
Stack trace:
#0 /Users/blk/sites/largo/wp-content/themes/largo/inc/nav-menus.php(128): Bootstrap_Walker_Nav_Menu->start_el('', Object(WP_Post), 0, Object(stdClass))
#1 /Users/blk/sites/largo/wp-includes/class-wp-walker.php(243): Bootstrap_Walker_Nav_Menu->display_element(Object(WP_Post), Array, 0, 0, Array, '')
#2 /Users/blk/sites/largo/wp-includes/nav-menu-template.php(531): Walker->walk(Array, 0, Object(stdClass))
#3 /Users/blk/sites/largo/wp-includes/nav-menu-template.php(191): walk_nav_menu_tree(Array, 0, Object(stdClass))
#4 /Users/blk/sites/largo/wp-content/themes/largo/inc/nav-menus.php(180): wp_nav_menu(Object(stdClass))
#5 /Users/blk/sites/largo/wp-content/themes/largo/partials/nav-sticky.php(138): largo_nav_menu(Array)
#6 /Users/blk/sites/largo/wp-includes/template.php(690): require('/Users/blk/site...')
#7 /Users/blk/sites/largo/wp-inc" while reading upstream, client: 127.0.0.1, server: largo.test, request: "GET / HTTP/2.0", upstream: "fastcgi://unix:/Users/blk/.config/valet/valet.sock:", host: "largo.test"

@benlk benlk mentioned this issue Feb 4, 2019
Merged
benlk added a commit that referenced this issue Feb 4, 2019
@benlk
Merge pull request #1625 from INN/1623-has_dhildren-notice
da020fe 
Fix for #1624 and #1623: Bootstrap_Nav_Walker::start_el() continued
@benlk
Copy link
Collaborator Author

benlk commented Feb 4, 2019

Closed with #1625, again, but let's keep awareness of this issue in case it reappears.

@benlk benlk closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. priority: low Nice-to-have in a release. type: bug
Projects
None yet
Milestone
0.6.2
Development

No branches or pull requests
1 participant
@benlk