Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "module" functionality for pull quotes doesn't work in Largo 0.6 for pull quotes created in Largo pre-0.4 #1639

Closed
benlk opened this issue Feb 28, 2019 · 0 comments · Fixed by #1645
Milestone

Comments

@benlk
Copy link
Collaborator

benlk commented Feb 28, 2019

Copying from INN/umbrella-lensnola#12:

From https://thelensnola.test/2019/01/22/two-perspectives-on-new-orleans-at-301-a-celebration-of-resilience-a-call-for-rebellion/

Example post content:

[module align="left" width="half" type="pull-quote"]Did Landrieu break with the past? It depends on how you see the past, not to mention the present and future.[/module] The spectacle of the monuments coming down was also intended to symbolize death leading to municipal rebirth. What was meant to die with the monuments was the “Lost Cause” myth that defeated Confederates used to reestablish white might. As Landrieu spoke a crowd gathered down the street, at the circle formerly known as Lee, to watch a crane operator hoist the last of the four statues off its 60-foot column of Tennessee marble, set atop a 24-foot pedestal of Georgia granite.

Output on page under Largo 0.3ish:

<p><aside class="module pull-quote left half">Did Landrieu break with the past? It depends on how you see the past, not to mention the present and future.</aside>The spectacle of the monuments coming down was also intended to symbolize death leading to municipal rebirth. What was meant to die with the monuments was the “Lost Cause” myth that defeated Confederates used to reestablish white might. As Landrieu spoke a crowd gathered down the street, at the circle formerly known as Lee, to watch a crane operator hoist the last of the four statues off its 60-foot column of Tennessee marble, set atop a 24-foot pedestal of Georgia granite.</p>

Output on page under Largo 0.6.1:

<p><aside class="module pull-quote left half"></aside>The spectacle of the monuments coming down was also intended to symbolize death leading to municipal rebirth. What was meant to die with the monuments was the “Lost Cause” myth that defeated Confederates used to reestablish white might. As Landrieu spoke a crowd gathered down the street, at the circle formerly known as Lee, to watch a crane operator hoist the last of the four statues off its 60-foot column of Tennessee marble, set atop a 24-foot pedestal of Georgia granite.</p>

Note that the aside is empty.

Testing in INN/umbrella-lensnola#12 showed that the problem persists without the child theme, so this is a bug in Largo.

@benlk benlk added this to the 0.6.2 milestone Feb 28, 2019
benlk added a commit that referenced this issue Mar 15, 2019
…ng displayed

This fixes a bug introduced in 351eda7 where $content was improperly changed to $atts['content'].

Fixes #1639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant