Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

largo_byline filter does not pass as filter argument the post ID specified as argument on function largo_byline() #1656

Closed
benlk opened this issue Mar 27, 2019 · 0 comments
Closed

largo_byline filter does not pass as filter argument the post ID specified as argument on function largo_byline() #1656

benlk opened this issue Mar 27, 2019 · 0 comments
Labels
type: bug
Milestone
0.6.2

Comments

@benlk
Copy link
Collaborator

benlk commented Mar 27, 2019

This is how the filter largo_byline works:

https://github.com/INN/largo/blob/480f5f884f3edc790192d23c2191748e8aec3634/inc/post-tags.php#L159-L166

But if get_the_ID is not specified, any filtering function that uses the post ID will probably get it wrong. So we need to pass those function arguments to the filter.

Originally reported in INN/umbrella-lensnola#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
0.6.2
Development

No branches or pull requests
1 participant
@benlk