Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply font-display:block to fontello #1686

Closed
benlk opened this issue Apr 23, 2019 · 3 comments
Closed

apply font-display:block to fontello #1686

benlk opened this issue Apr 23, 2019 · 3 comments
Assignees
@joshdarby
Labels
category: styles affects lots of styles, requiring visual testing Estimate: < 2 Hours priority: low Nice-to-have in a release. type: improvement
Milestone
0.6.4

Comments

@benlk
Copy link
Collaborator

benlk commented Apr 23, 2019

https://developers.google.com/web/updates/2016/02/font-display

block

block gives the font face a short block period (3s is recommended in most cases) and an infinite swap period. In other words, the browser draws "invisible" text at first if the font is not loaded, but swaps the font face in as soon as it loads. To do this the browser creates an anonymous font face with metrics similar to the selected font but with all glyphs containing no "ink." This value should only be used if rendering text in a particular typeface is required for the page to be useable.
@benlk benlk added type: improvement priority: low Nice-to-have in a release. category: styles affects lots of styles, requiring visual testing labels Apr 23, 2019
@benlk benlk added this to the 0.6.3 milestone Apr 23, 2019
@benlk
Copy link
Collaborator Author

benlk commented May 13, 2019

This is a temporary fix for #1497

@joshdarby
Copy link
Collaborator

@benlk Does this just involve adding that font-display attribute here?

https://github.com/INN/largo/blob/67b4dedb252220515243756e96ed2033dd7f0d38/less/inc/icons.less#L1-L7

@benlk
Copy link
Collaborator Author

benlk commented Jul 10, 2019

Yes.

@joshdarby joshdarby mentioned this issue Jul 10, 2019
Merged
1 task
@joshdarby joshdarby self-assigned this Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshdarby joshdarby

Labels
category: styles affects lots of styles, requiring visual testing Estimate: < 2 Hours priority: low Nice-to-have in a release. type: improvement
Projects
None yet
Milestone
0.6.4
Development

No branches or pull requests
3 participants
@benlk @joshdarby @MirandaEcho