Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP 5.2: Add support for wp_body_open hook #1698

Closed
benlk opened this issue Apr 26, 2019 · 0 comments
Closed

WP 5.2: Add support for wp_body_open hook #1698

benlk opened this issue Apr 26, 2019 · 0 comments
Assignees
@joshdarby
Labels
Estimate: < 2 Hours priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: feature request
Milestone
0.6.4

Comments

@benlk
Copy link
Collaborator

benlk commented Apr 26, 2019 •
edited
Loading

https://make.wordpress.org/core/2019/04/24/miscellaneous-developer-updates-in-5-2/

https://generatewp.com/wordpress-5-2-action-that-every-theme-should-use/

With the eventual goal of submitting Largo to the theme directory, we should use the alternate formulation listed in that post for the fallback in event of the wp_body_open() function not existing:

<body <?php body_class(); ?>>
<?php 
if ( function_exists( 'wp_body_open' ) ) {
    wp_body_open();
} else {
    do_action( 'wp_body_open' );
}
@benlk benlk added this to the 0.6.4 milestone Apr 26, 2019
@benlk benlk added the priority: high Either blocks work on a priority-normal task or a solution here informs other work. label Jun 19, 2019
@joshdarby joshdarby self-assigned this Jul 8, 2019
@joshdarby joshdarby mentioned this issue Jul 9, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshdarby joshdarby

Labels
Estimate: < 2 Hours priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: feature request
Projects
None yet
Milestone
0.6.4
Development

No branches or pull requests
3 participants
@benlk @joshdarby @MirandaEcho