Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions to .wp-block-quote and .wp-block-pullquote styles #1699

Closed
benlk opened this issue Apr 26, 2019 · 7 comments
Closed

Revisions to .wp-block-quote and .wp-block-pullquote styles #1699

benlk opened this issue Apr 26, 2019 · 7 comments
Assignees
Labels
category: gutenberg Relating to general Gutenberg compatibility category: styles affects lots of styles, requiring visual testing Estimate: < 6 Hours priority: normal Must be completed before release of this version of plugin. status: in progress type: bug type: feature request
Milestone

Comments

@benlk
Copy link
Collaborator

benlk commented Apr 26, 2019

This will require significant duplication of styles, because the markup for a Quote block

<blockquote class="wp-block-quote">
<p>This is a standard WordPress Quote block</p>
<cite>It has a citation.</cite>
</blockquote>

Does not match the markup for a Pull Quote block:

<figure class="wp-block-pullquote">
<blockquote>
<p>This is a <a href="https://wordpress.org/support/article/pullquote-block/">Pullquote</a> block, which is different from a Quote block.</p>
<cite>WordPress</cite>
</blockquote>
</figure>

Note how .wp-block-pullquote is applied, not to the blockquote element, but to the containing figure element.

@benlk benlk added type: bug type: feature request category: styles affects lots of styles, requiring visual testing category: gutenberg Relating to general Gutenberg compatibility labels Apr 26, 2019
@benlk benlk added this to the 0.6.4 milestone Apr 26, 2019
@benlk
Copy link
Collaborator Author

benlk commented Apr 26, 2019

Alternately:

Apply the .type-pull-quote styles to Pull Quote block. Add the aside styles from the Module Wrapper as an alternate-style option to the pull quote block.

See generally WordPress/gutenberg#11610

@benlk
Copy link
Collaborator Author

benlk commented Apr 30, 2019

User comment:

Also, I question why you made this change: "Matches the default styles for Gutenberg's Pull Quote block with Largo's styles for <blockquote>." Blockquotes and pull quotes are different stylistic elements, and I'm not sure why anyone would want them to look the same. A pull quote is supposed to add visual flair beyond what a blockquote presents. Or maybe I'm at odds with what most other sites do on this.

This would be in favor of the alternate approach described above.

@MirandaEcho MirandaEcho added Category: Gutenberg Compatibility Estimate Needed and removed category: gutenberg Relating to general Gutenberg compatibility labels May 21, 2019
@benlk benlk added category: gutenberg Relating to general Gutenberg compatibility and removed Category: Gutenberg Compatibility labels May 22, 2019
@benlk
Copy link
Collaborator Author

benlk commented Jun 6, 2019

  • remove pull quote styles from block quote, leaving only block quote styles.
  • apply pull quote styles to pull quote block.

@benlk benlk changed the title Make styles for .wp-block-quote apply also to .wp-block-pullquote Revisions to .wp-block-quote and .wp-block-pullquote styles Jun 6, 2019
@benlk benlk added the priority: normal Must be completed before release of this version of plugin. label Jun 19, 2019
@joshdarby joshdarby self-assigned this Jul 10, 2019
@joshdarby
Copy link
Collaborator

@benlk I went ahead and removed the normal block quote styles from the pull quote and added the type-pull-quote styles to it. Anything else we're looking for in this specific issue?

Screen Shot 2019-07-11 at 3 12 28 PM

@benlk
Copy link
Collaborator Author

benlk commented Jul 12, 2019

Does it look okay in alignment left/right/center/none conditions?

@joshdarby
Copy link
Collaborator

@benlk I think so. Here's how it looks.

Left:
Screen Shot 2019-07-12 at 4 29 23 PM

Right:
Screen Shot 2019-07-12 at 4 28 05 PM

Full-width:
Screen Shot 2019-07-12 at 4 30 32 PM

Wide:
Screen Shot 2019-07-12 at 4 30 08 PM

Normal:
Screen Shot 2019-07-12 at 4 31 45 PM

@benlk
Copy link
Collaborator Author

benlk commented Jul 12, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: gutenberg Relating to general Gutenberg compatibility category: styles affects lots of styles, requiring visual testing Estimate: < 6 Hours priority: normal Must be completed before release of this version of plugin. status: in progress type: bug type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants