Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add box-sizing: border-box to navis slideshow caption CSS #1702

Closed
benlk opened this issue Apr 29, 2019 · 4 comments
Closed

Add box-sizing: border-box to navis slideshow caption CSS #1702

benlk opened this issue Apr 29, 2019 · 4 comments
Assignees
@joshdarby
Labels
category: images Issues relating to images category: styles affects lots of styles, requiring visual testing Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. status: in progress type: bug
Milestone
0.6.4

Comments

@benlk
Copy link
Collaborator

benlk commented Apr 29, 2019

https://github.com/INN/largo/blob/e2ac830239452658c285860b330d521c6a0f300e/lib/navis-slideshows/css/slides.css#L306-L317

Add this:

    box-sizing: border-box;

This will change the caption of an image from this first image to the second image:

Screen Shot 2019-04-29 at 18 13 50

Screen Shot 2019-04-29 at 18 13 39

@benlk benlk added type: bug category: styles affects lots of styles, requiring visual testing labels Apr 29, 2019
@benlk benlk added this to the 0.6.4 milestone Apr 29, 2019
@joshdarby joshdarby self-assigned this May 14, 2019
@joshdarby
Copy link
Collaborator

@benlk Should this also be added to .wp-block-gallery .blocks-gallery-image figcaption, .wp-block-gallery .blocks-gallery-item figcaption?

@benlk
Copy link
Collaborator Author

benlk commented May 14, 2019

Yes. Anywhere there's a figcaption or .wp-caption-text, basically.

@joshdarby joshdarby mentioned this issue May 20, 2019
Merged
@MirandaEcho MirandaEcho added category: images Issues relating to images Estimate Needed labels May 21, 2019
@joshdarby
Copy link
Collaborator

This is awaiting review in #1711.

@benlk benlk added status: in progress priority: normal Must be completed before release of this version of plugin. labels Jun 18, 2019
@benlk
Copy link
Collaborator Author

benlk commented Jul 10, 2019

Let's create an issue for better automated frontend testing in the future, but continue testing this with our existing testing stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshdarby joshdarby

Labels
category: images Issues relating to images category: styles affects lots of styles, requiring visual testing Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. status: in progress type: bug
Projects
None yet
Milestone
0.6.4
Development

No branches or pull requests
3 participants
@benlk @joshdarby @MirandaEcho