Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReferenceError: Can't find variable: hasEvent #1714

Open
benlk opened this issue May 23, 2019 · 2 comments · Fixed by #1715
Open

ReferenceError: Can't find variable: hasEvent #1714

benlk opened this issue May 23, 2019 · 2 comments · Fixed by #1715
Labels
Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: bug
Milestone
0.7 - Foundation ...

Comments

@benlk
Copy link
Collaborator

benlk commented May 23, 2019

https://github.com/INN/largo/blob/06cdb060774452911c3fc87eafd70908e58724ab/js/navigation.js#L75-L78

This instance of hasEvent should probably be Modernizr.hasEvent
@benlk benlk added this to the 0.6.4 milestone May 23, 2019
benlk added a commit that referenced this issue May 23, 2019
@benlk
Fix ReferenceError in navigation.js
cb41b06 
Fixes #1714
This was referenced May 23, 2019
Closed
Merged
@benlk benlk added priority: high Either blocks work on a priority-normal task or a solution here informs other work. and removed status: in progress labels Jun 25, 2019
@benlk
Copy link
Collaborator Author

benlk commented Jun 25, 2019

Report from Voice of OC: this breaks the sticky nav in Safari.

@benlk benlk added priority: normal Must be completed before release of this version of plugin. and removed priority: high Either blocks work on a priority-normal task or a solution here informs other work. labels Oct 31, 2019
@benlk
Copy link
Collaborator Author

benlk commented Oct 31, 2019

@benlk benlk reopened this Oct 31, 2019
@benlk benlk mentioned this issue Oct 31, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: bug
Projects
None yet
Milestone
0.7 - Foundation for Customization
Development

Successfully merging a pull request may close this issue.

Fix ReferenceError in navigation.js WPBuddy/largo
1 participant
@benlk