Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the RSS feed is bad, the INN Member Stories widget breaks the site #893

Closed
2 tasks
benlk opened this issue Sep 8, 2015 · 3 comments
Closed
2 tasks

If the RSS feed is bad, the INN Member Stories widget breaks the site #893

benlk opened this issue Sep 8, 2015 · 3 comments
Labels
status: wontfix type: tech debt For necessary updates because code is old
Milestone
0.6 - Gutenberg, ...

Comments

@benlk
Copy link
Collaborator

benlk commented Sep 8, 2015

If http://feeds.feedburner.com/INNMemberInvestigations is not a parseable URL, (fetched in line 20 of the widget, then the following error occurs and causes the page to stop rendering. This breaks the page.

[Tue Sep 08 12:30:04 2015] [error] [client 192.168.33.1] PHP Fatal error:  Call to undefined method WP_Error::get_items() in /vagrant/wp-content/themes/largo-dev/inc/widgets/largo-inn-rss.php on line 72

A fix for this would:

  • check to see that the RSS feed loads successfully before trying to parse it
  • if it fails to load successfully, display an error message of some sort.
@benlk benlk added the type: bug label Sep 8, 2015
@rclations rclations modified the milestone: Backlog Apr 11, 2017
@rclations rclations modified the milestones: 0.6 - Performance & SEO, Backlog Jun 10, 2017
@rclations
Copy link

moving to inn members plugin repo, as I've already removed the underlying code for this from largo 🎉

@benlk benlk reopened this Aug 3, 2018
@benlk
Copy link
Collaborator Author

benlk commented Aug 3, 2018

Reopening this because the code hasn't been removed from the released Largo versions.

@benlk benlk added priority: normal Must be completed before release of this version of plugin. type: tech debt For necessary updates because code is old labels Aug 3, 2018
This was referenced Aug 3, 2018
Closed
Closed
@benlk
Copy link
Collaborator Author

benlk commented Aug 10, 2018

Closing in favor of #1511, which will remove the widget. The widget and the RSS feed it depends on are deprecated.

@benlk benlk closed this as completed Aug 10, 2018
@benlk benlk added status: wontfix and removed priority: normal Must be completed before release of this version of plugin. type: bug labels Aug 10, 2018
@benlk benlk mentioned this issue Sep 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: wontfix type: tech debt For necessary updates because code is old
Projects
None yet
Milestone
0.6 - Gutenberg, SEO, Performance
Development

No branches or pull requests
2 participants
@benlk @rclations