Make $post_id protected, not private #1333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Makes the property
$post_id
ofLargo_Byline
protected, not private, so that whenLargo_CoAuthors_Byline
extendsLargo_Byline
and usesLargo_Byline
's methods__construct
andpopulate_vars
,Largo_CoAuthors_Byline
will be able to read the variable that it tries to set.Otherwise, anything in
Largo_CoAuthors_Byline
that uses$this->post_id
gets a big fatnull
, and usually tries to work based off of the current post in The Loop.This is only a bug when calling
largo_byline
with a post ID specified.