Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make $post_id protected, not private #1333

Merged
merged 1 commit into from Oct 8, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Oct 7, 2016

Changes

Makes the property $post_id of Largo_Byline protected, not private, so that when Largo_CoAuthors_Byline extends Largo_Byline and uses Largo_Byline's methods __construct and populate_vars, Largo_CoAuthors_Byline will be able to read the variable that it tries to set.

Otherwise, anything in Largo_CoAuthors_Byline that uses $this->post_id gets a big fat null, and usually tries to work based off of the current post in The Loop.

This is only a bug when calling largo_byline with a post ID specified.

@benlk benlk added the priority: high Either blocks work on a priority-normal task or a solution here informs other work. label Oct 7, 2016
@benlk benlk added this to the 0.5.5 - Story Elements milestone Oct 7, 2016
@aschweigert aschweigert merged commit fe73f2b into develop Oct 8, 2016
@aschweigert aschweigert deleted the 1322-make-post_id-protected branch October 8, 2016 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants