Add .screen-reader-text CSS class, improve homepage CSS imports #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For single.less, as part of this, move variables to less/inc/variables.less: - variable `@grey` (local to single.less) is replaced by the theme color variable `@grayDark`; this changes the color from #777 to the darker #484848 - variable `@fog` is replaced by the theme color variable `@grayLighter`; this changes no colors - variable `@sky` moves to less/inc/variables.less As a result of switching to `(reference)` for the imports, top-stories.css (unminified) loses several dozen lines of comment-only CSS. http://lesscss.org/features/#import-atrules-feature-reference
|
Tyler says it's okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.screen-reader-textCSS class using.visuallyhidden.visuallyhiddentechnique to match the October 2017 update from https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/(reference)imports on homepage stylesheetshomepages/assets/less/single.less:@grey(local to single.less) is replaced by the theme color variable@grayDark; this changes the color from Remove all the border-radiuses > 0 #777 to the darker #484848@fogis replaced by the theme color variable@grayLighter; this changes no colors@Skymoves to less/inc/variables.lessWhy
Adding
.screen-reader-textfixes #1528 as part of #844.The switch to
(reference)is because I noticed that the homepage stylesheets were picking up the.visuallyhiddenchanges; they don't need to duplicate the mixin classes if the rules are already included in Largo's mainstyle.cssandstyle.min.css. This decreases duplication of styles.The colors moved from
single.lesstovariables.lessbecause doing so allowed:variables.lessQuestions
@tyler Is it okay to switch from that slightly-lighter grey to a slightly-darker grey? We go from a WCAG 2.0 AAA contrast level to a slightly-higher-contrast WCAG 2.0 AAA contrast level.
original:
new: