In Bootstrap_Walker_Nav_Menu::start_el(), stop referring to array keys as object properties, and set visibility of methods.

[benlk]

Changes

• In Bootstrap_Walker_Nav_Menu::start_el(), replaces $array->key markup with $array['key'], because that's the way to do things, for Highly annoying debug notice in sticky nav #1623 and All the undefined indexes. All the uninitialized variables. #1492
• Sets method visibility on all methods of Bootstrap_Walker_Nav_Menu.

Why

Because the Notice in #1623 was repeated all over the screen, rendering the menu unusable when WP_DEBUG was true.

Because PHP notices should be eliminated, as part of #1492.

Because class methods require visibility to be declared in good code.

Testing

• Compare markup from this class before and after this commit has been applied. They should be identical.
• Compare markup from this commit and from v0.5.5.4. They should be identical.

[benlk]

There's no difference between 0.5-dev and this branch; the differences between v0.5.5.4 and this branch are what was expected from v0.6.1.

v0.5.5.4.txt
0.5-dev.txt
branch.txt