Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1624 and #1623: Bootstrap_Nav_Walker::start_el() continued #1625

Merged
merged 3 commits into from
Feb 4, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Feb 4, 2019

Changes

As noted in #1623 (comment), cannot use object of type stdClass as array in largo/inc/nav-menus.php:87. This PR reverts to the pre-#1624 behavior of accessing the various aspects of the $args argument as object properties, not as array keys.

I'm not sure what caused #1623, in the end, and that's worrisome.

However, this patch unbreaks the error that #1624 introduced.

@benlk benlk added type: bug priority: high Either blocks work on a priority-normal task or a solution here informs other work. labels Feb 4, 2019
@benlk benlk added this to the 0.6.2 milestone Feb 4, 2019
@benlk
Copy link
Collaborator Author

benlk commented Feb 4, 2019

Testing

  • Compare markup from this class before and after this commit has been applied. They should be identical.
  • Compare markup from this commit and from v0.5.5.4. They should be identical.

@benlk
Copy link
Collaborator Author

benlk commented Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant