Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent header/footer ad widget containers from going beyond the viewport #1673

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Prevent header/footer ad widget containers from going beyond the viewport #1673

merged 1 commit into from
Apr 20, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Apr 20, 2019

Fixes #1670

@benlk benlk added type: bug category: styles affects lots of styles, requiring visual testing labels Apr 20, 2019
@benlk benlk added this to the 0.6.2 milestone Apr 20, 2019
@benlk benlk merged commit cb81250 into 0.5-dev Apr 20, 2019
@benlk benlk deleted the 1670-border-boxing branch July 19, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: styles affects lots of styles, requiring visual testing type: bug
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

Add box-sizing: border-box; to #header-ad-zone-container, #before-footer
1 participant
@benlk