Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme support for responsive-embeds #1689

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Apr 24, 2019

Resolves #1688, and answers the ultimate question of #1572 in how $content_width was being overridden by Gutenberg: with CSS.

@benlk benlk added type: bug priority: normal Must be completed before release of this version of plugin. type: feature request category: gutenberg Relating to general Gutenberg compatibility labels Apr 24, 2019
@benlk benlk added this to the 0.6.2 milestone Apr 24, 2019
benlk added a commit to INN/umbrella-innsandbox that referenced this pull request Apr 24, 2019
@benlk
Copy link
Collaborator Author

benlk commented Apr 24, 2019

Before (with pesticide.io to show the block boundaries):

Screen Shot 2019-04-24 at 10 46 42

After:

Screen Shot 2019-04-24 at 10 58 36

After, on a two-column template:

Screen Shot 2019-04-24 at 10 59 49

@benlk benlk merged commit c530c6f into 0.5-dev Apr 24, 2019
@benlk benlk deleted the 1688-theme-support-responsive-embeds branch April 24, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: gutenberg Relating to general Gutenberg compatibility priority: normal Must be completed before release of this version of plugin. type: bug type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declare theme support for responsive embeds
1 participant