Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ensemble slides into bagging and boosting #471

Merged
merged 14 commits into from
Jan 11, 2022

Conversation

ArturoAmorQ
Copy link
Collaborator

@ArturoAmorQ ArturoAmorQ commented Oct 15, 2021

This PR adds the slides bagging.md and boosting.md that result from splitting ensemble.md.

Doing so required the refactoring of the quizzes in M6 and modifying the toc.yml file accordingly.

It also adds spacing to the tables in the custom.css file.

Note to ourselves: This PR has to be merged along with the respective gitlab MR.

@lesteve lesteve added the FUN:requires changes This will require manual changes in FUN label Jan 6, 2022
@lesteve
Copy link
Collaborator

lesteve commented Jan 6, 2022

Would be it worth doing related things in the same PR or is it better to leave it for a further PR, not sure ...

Here is the kind of things I have in mind:

  • remove slides/ensemble.md?
  • update the JupyterBook to put the slides in the right place?

@ogrisel
Copy link
Collaborator

ogrisel commented Jan 10, 2022

I started reviewing the private MR with the quiz answers: https://gitlab.inria.fr/learninglab/mooc-scikit-learn/mooc-scikit-learn-coordination/-/merge_requests/36

Copy link
Collaborator

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogrisel ogrisel merged commit ac011b5 into INRIA:main Jan 11, 2022
github-actions bot pushed a commit that referenced this pull request Jan 11, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> ac011b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FUN:requires changes This will require manual changes in FUN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants